Protect savestates while the threaded software renderer is running #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le it's being serialized
JesseTG
changed the title
|
Okay, I think I've fixed the crash that I cited, and without affecting performance.
That blue circle represents the only instance of lock contention in the trace file I took. |
|
I'm about to refactor |
# Conflicts: # src/GPU3D.cpp # src/GPU3D_Soft.cpp # src/GPU3D_Soft.h
|
@RSDuck Would you mind taking a look at this PR when you have some time? I recall from our discussions on Discord that you have some reservations about it, but I'm not clear on what the issues are. This is probably one of the last PRs I need before I'm ready to release melonDS DS 1.0. |
- It's recalculated anyway
- I liked the dialogue style, but oh well
- Let's see what happens
- Taking the difference between two pointers results in the number of elements, not the number of bytes
- The real synchronization was the friends we made along the way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In upstream melonDS, the frontend has full control of when it takes savestates, so you can assume that the render thread won't try to run while a savestate is being taken or loaded.
I can't make that assumption, as libretro doesn't let cores control when savestates are taken. End result is this issue, which this PR aims to fix.